dhall-kubernetes icon indicating copy to clipboard operation
dhall-kubernetes copied to clipboard

Published 20 hours ago • verified publisher icon dhall-lang

Remove metadata.name from podTemplate

Open arianvp opened this issue 5 years ago • 6 comments

makes it more in-line with a normal Kubernetes deployment example. This field is even ignored by kubernetes API for PodTemplates afaik

Also deploymentSimple was missing a selector which is invalid (runtime error)

arianvp avatar Aug 12 '20 12:08 arianvp

I think I also need to update the files in out?

Would also be nice that we test that dhall-to-yaml | yaml-to-dhall | dhall-to-yaml roundtrips on all examples as a sanity check

arianvp avatar Aug 12 '20 13:08 arianvp

Oh indeed, it seems like the hydra job does not check that.

TristanCacqueray avatar Aug 12 '20 13:08 TristanCacqueray

it used to though if I remember correctly ... did something change? :/

arianvp avatar Aug 12 '20 14:08 arianvp

@arianvp: It did check this. I'm also surprised, and I'm looking into this.

Gabriella439 avatar Aug 12 '20 15:08 Gabriella439

@arianvp: It looks like the issue is that after my changes CI only checks the versioned releases, but not the top-level default release. I'll put up a PR soon to fix that

Gabriella439 avatar Aug 13 '20 15:08 Gabriella439

@arianvp: Alright, CI is fixed now to catch when things get out of sync. See the CI error on this pull request after merging in master

Gabriella439 avatar Sep 12 '20 01:09 Gabriella439