ristretto
ristretto copied to clipboard
dgraph-io
remove glog dependency
updated go mod deps
glog adds global flags so it is not a good library (adding to an existing program causes a panic if a flag name conflicts)
This change is 
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 4 committers have signed the CLA.
:white_check_mark: hawkingrei
:white_check_mark: jhawk28
:x: chux0519
:x: manishrjain
You have signed the CLA already but the status is still pending? Let us recheck it.
Can we please merge this. Glog spins off a go routine that cannot be closed on it's init() function, breaking unit tests that check for go routine leaks.
@NamanJain8
Can we please merge this. Glog spins off a go routine that cannot be closed on it's
init()function, breaking unit tests that check for go routine leaks.
Ditto. @mangalaman93
Glog is not intended for use outside Google:
The repository contains an open source version of the log package used inside Google. The master copy of the source lives inside Google, not here. The code in this repo is for export only and is not itself under development. Feature requests will be ignored.
Why is this PR still unmerged??
@mholt , I maintain a fork of ristretto. I have this and other fixes, if you want to use that. I know Datadog uses my fork.
https://github.com/outcaste-io/ristretto/commit/bd658a460d49079c51c64cad7c1634c42df7a0ef
@manishrjain Thanks; since this is a dependency of a dependency of a ... (x4) ... I suppose I will use a replace in my go.mod -- that might do...
@mholt will it be possible for you rebase it on latest main instead of mater. I already changed the base branch here to main. Apologies for the delay. Thanks
@mangalaman93 Thanks; this isn't my PR though, @jhawk28 would have to do that.
I did a rebase but it didn't appear to work correctly. I would recommend just creating another PR.