ristretto icon indicating copy to clipboard operation
ristretto copied to clipboard

fix: remove polluting google log library

Open aeneasr opened this issue 3 years ago • 5 comments

For more context please see discussion https://discuss.dgraph.io/t/ristretto-0-1-0-pollutes-the-flags-namespace/14561

By reverting #263 not only is the number of dependencies this library has greatly reduced, but projects using this library will not unavoidably panic.


This change is Reviewable

aeneasr avatar Jan 20 '22 21:01 aeneasr

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Jan 20 '22 21:01 CLAassistant

@manishrjain hey, can this be merged? glog pollutes our binary flags. Thanks!

floatdrop avatar Feb 20 '22 11:02 floatdrop

Hey @floatdrop ,

I'm no longer associated with Dgraph Labs. I'm not maintaining repositories owned by dgraph-io. I've forks of these repos in outcaste-io. If you want to switch to that and send me the PR, I'll be happy to review it.

https://github.com/outcaste-io/ristretto

manishrjain avatar Feb 21 '22 16:02 manishrjain

Is anyone maintaing this repo or is it essentially abandoned?

aeneasr avatar Mar 23 '22 18:03 aeneasr

@aeneasr Abandoned, check out https://github.com/outcaste-io/ristretto

karlmcguire avatar Mar 23 '22 23:03 karlmcguire

A similar PR is merged now https://github.com/dgraph-io/ristretto/pull/350

mangalaman93 avatar Aug 31 '23 06:08 mangalaman93