David Grudl comments

Results 429 comments of


                                            David Grudl

trafficstars

FirebirdDriver::escapeLike Dibi\NotImplementedException

Can you try to do it and send a pull request?

FirebirdDriver::escapeLike Dibi\NotImplementedException

Thanks

FirebirdDriver::escapeLike Dibi\NotImplementedException

Are you sure that this solution is correct? According to http://www.janus-software.com/fbmanual/manual.php?book=psql&topic=82 `If the escape clause is ommitted, then there is no default escape character.`.

FirebirdDriver::escapeLike Dibi\NotImplementedException

Asi jo, ale musí se to otestovat. Zkusil jsem přidat test. https://github.com/dg/dibi/commit/0fb63f3e6b1370f5b1c5bf5b4253728d658a30ea

PdoException leakage - API encapsulation breakage

I would prefer to go with a) in 4.0.x & 3.2.x and c) for 4.1.0. Can you implement it?

PdoException leakage - API encapsulation breakage

Thanks!

Allow $query->from()->select()

Can you try to fix it?

count() on \Dibi\Fluent with offset does not work

Why?

count() on \Dibi\Fluent with offset does not work

Hmmm, it is due to c26201c75d9ec30dcb23720a7753efc9f6727c2a. Workaround is to use `'SELECT COUNT(*) FROM (', $fluent, ') [data]'`.

count() on \Dibi\Fluent with offset does not work

Problem is that translator is NOT cloned when you use `%ex`, see https://github.com/dg/dibi/blob/0cce3b99160d1e7638bcb24370da9b3ba3f8a8c4/src/Dibi/Translator.php#L529.