sdk icon indicating copy to clipboard operation
sdk copied to clipboard

fix: Rust crate names are underscore in metadata

Open bitdivine opened this issue 1 year ago • 0 comments
trafficstars

Description

Rust expresses crate names with both hyphens and underscores but the metadata uses only underscores. For example, ic-cdk is a dependency of the sdk repo, but in cargo metadata it appears as ic_cdk. The match rule in canister_info::rust doesn't take this into account, causing spurious errors for canisters with hyphens in their name.

Fixes # (issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

Checklist:

  • [ ] The title of this PR complies with Conventional Commits.
  • [ ] I have edited the CHANGELOG accordingly.
  • [ ] I have made corresponding changes to the documentation.

bitdivine avatar Sep 11 '24 16:09 bitdivine