ic icon indicating copy to clipboard operation
ic copied to clipboard

chore(ecdsa): Replace nested if-match-if's with a single match

Open kpop-dfinity opened this issue 1 year ago • 4 comments

Replaced

if {
  match  {
    None => if {} else {}
    Some => if {} else {} 
  }
} else {
  match  {
    None => if {} else {}
    Some => if {} else {} 
  }
},

which was hardly readable for me, with one big match

kpop-dfinity avatar Jun 04 '24 15:06 kpop-dfinity

@kpop-dfinity you want to make sure that your commit https://github.com/dfinity/ic/pull/180/commits/a81e239b904baf3f512280539b8355b42d4900ec is based of the mirroring branch instead of master. Otherwise your PR will show commits like https://github.com/dfinity/ic/pull/180/commits/cb05b9165b3721f97e5bfc290e95d8d8d6263ea1 which are already in master but not yet in mirroring.

basvandijk avatar Jun 04 '24 16:06 basvandijk

@kpop-dfinity you want to make sure that your commit a81e239 is based of the mirroring branch instead of master. Otherwise your PR will show commits like cb05b91 which are already in master but not yet in mirroring.

hmmm, I thought I did, I must have done something wrong

kpop-dfinity avatar Jun 05 '24 08:06 kpop-dfinity

One of the failures in the failing "CI Main / Bazel Build All Config Check (pull_request)" job will be fixed by https://github.com/dfinity/ic/pull/188. Not sure yet about the other failures though...

basvandijk avatar Jun 06 '24 08:06 basvandijk

One of the failures in the failing "CI Main / Bazel Build All Config Check (pull_request)" job will be fixed by #188. Not sure yet about the other failures though...

Great, thanks for looking into it!

kpop-dfinity avatar Jun 06 '24 14:06 kpop-dfinity