ic-js icon indicating copy to clipboard operation
ic-js copied to clipboard

Published 20 hours ago • verified publisher icon dfinity

feat: update nns-proto

Open peterpeterparker opened this issue 1 year ago • 1 comments

Motivation

According hours spent today and discussion on the forum there is no other solution currently to install the NNS Governance canister with JavaScript than having to use proto.

Changes

  • Bump .proto file in @dfinity/nns-proto
  • Copy the proto base files without manipulating those manually (that's why there are more files that just base_types)
  • Export more types in index module
  • Remove BlockHeight and ICPTs from exported types because, those does not exist anymore in proto file
  • Add the dev depency protoc-gen-js because somehow running protoc to update the proto file did not work anymore without it

peterpeterparker avatar May 10 '24 15:05 peterpeterparker

size-limit report 📦

Path Size
@dfinity/ckbtc 7.24 KB (0%)
@dfinity/cketh 2.94 KB (0%)
@dfinity/cmc 1.29 KB (0%)
@dfinity/ledger-icrc 3.6 KB (0%)
@dfinity/ledger-icp 14.73 KB (0%)
@dfinity/nns 34.57 KB (0%)
@dfinity/nns-proto 140.98 KB (+84.43% 🔺)
@dfinity/sns 15.72 KB (0%)
@dfinity/utils 4.46 KB (0%)
@dfinity/ic-management 2.58 KB (0%)

github-actions[bot] avatar May 10 '24 18:05 github-actions[bot]

(Closed and Reopened the PR to relaunch the CI given that GitHub experienced issues with Actions)

peterpeterparker avatar May 13 '24 20:05 peterpeterparker