Paul Gschwendtner

Results 146 comments of Paul Gschwendtner
trafficstars

@nickdobson Yeah, we likely need to discuss this more with the team. Good point.

@atscott is `Navigation` (the `implements Navigation` part) referring to a browser global of `dom.d.ts`? seems like this fails to resolve.

I can look more, but maybe the type package is not mentioned in the API golden rule via the "types" attributr

@atscott I tried reproducing this locally, but not sure if you are seeing the same, but I don't even see these failures on my end? ``` ~/projects/angular @fd22a511 *73 git...

This should be fixed now with https://github.com/angular/angular/pull/54309

This would be even better, either re-using that logic, or disabling it completely sounds even better.

@pmvald do we actually still need this PR if we disable extra imports in global compilation?

Oh makes sense. Thanks for clarifying again. I think I messed up these two things, thinking this would not be needed. Will review again tomorrow morning

/benchmark-compare main //modules/benchmarks/src/expanding_rows:perf_chromium

I saw similar issues and considered it as expected when using a div as container. If a span is used the newline in the markup doesn't contribute as a space