devtron icon indicating copy to clipboard operation
devtron copied to clipboard

fix: Fix the incorrect parameter order

Open cuishuang opened this issue 1 year ago • 5 comments

Description

Fix the incorrect parameter order

Fixes #

Checklist:

  • [ ] The title of the PR states what changed and the related issues number (used for the release note).
  • [ ] Does this PR requires documentation updates?
  • [ ] I've updated documentation as required by this PR.
  • [ ] I have performed a self-review of my own code.
  • [ ] I have commented my code, particularly in hard-to-understand areas.
  • [ ] I have tested it for all user roles.
  • [ ] I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?


cuishuang avatar Sep 27 '24 08:09 cuishuang

Hi @cuishuang , can you please change the target branch to develop ? We are in transition to manage releases from develop branch

ayu-devtron avatar Sep 30 '24 12:09 ayu-devtron

Hi @cuishuang , can you please change the target branch to develop ? We are in transition to manage releases from develop branch

Modified. Please review again.

cuishuang avatar Sep 30 '24 17:09 cuishuang

Thanks @cuishuang. We will consider this as part of next release

ayu-devtron avatar Oct 01 '24 07:10 ayu-devtron

Thanks @cuishuang. We will consider this as part of next release

Thanks!

cuishuang avatar Oct 01 '24 08:10 cuishuang

The new pr https://github.com/devtron-labs/devtron/pull/6461

cuishuang avatar Mar 21 '25 05:03 cuishuang