snek comments

Results 461 comments of


                                            snek

vm: references to context inside objects are not === the original context

i can noodle around with this and my current pr count drops a little bit i'll see if i can do something actionable

vm: references to context inside objects are not === the original context

so far my idea basically revolves around separating sandbox and global object ```js > const g = process.binding('contextify').makeContext({ a: 1 }, { name: 'owo' }) undefined > g.global = g...

Document how to build from source with full debuginfo

passing `V8_FROM_SOURCE=1 GN_ARGS="line_tables_only=false no_inline_line_tables=false symbol_level=2 use_debug_fission=false"` should work i think.

Namespace Abseil to prevent symbol collisions across dependencies

IIRC crates.io will not accept publishing this due to it modifying its own source. Can you double check with `cargo publish --dry-run`?

Namespace Abseil to prevent symbol collisions across dependencies

looks like a transient network issue yes. wrt publishing, I don't think we can accept using --allow-dirty, just to ensure the integrity of what we are publishing.

Namespace Abseil to prevent symbol collisions across dependencies

can you update the other things you use that rely on abseil?

Namespace Abseil to prevent symbol collisions across dependencies

That file needs to be present for building from source right?

Namespace Abseil to prevent symbol collisions across dependencies

Yes I'm saying, building the crates.io release from source is currently a supported feature.

fix(ext/http): make `Deno.ServeDefaultExport` generic

given that this code path is reachable (e.g. `DENO_SERVE_ADDRESS=vsock:-1:8080 deno serve -A --unstable-vsock test.ts`) I think this PR makes more sense than the one removing the logging logic.

Unsoundness when starting an isolate per thread

This is correct, `v8::Isolate` is not a thread safe type. Lockers (https://github.com/denoland/rusty_v8/issues/643) would allow this.