Joseph Schuchart
Joseph Schuchart
What is the status of this PR? The `[WIP]` label has been removed a while ago and a review was requested. However, there still seems to be work going on...
> I would not consider the build*.sh scripts a good place to document CMake variables. why not inside CMakeLists.txt into the options()? We can move it to the `options` in...
> AFAIK we chose these constraints because we want to be able to do a simple `memcpy` in DART by using Shared Memory Windows. But `std::memcpy()` does not require a...
You're right, `is_trivially_copyable` includes `!is_polymorphic`. Please ignore `!is_polymorphic` then :)
For the record: default construction of elements in containers has been brought up in https://github.com/dash-project/dash/issues/479.
Sorry, this PR completely slipped through. Just a minor question, seems fine to me otherwise
You can still atomically read/write/cas structs for which `sizeof(T)
> @devreal: I see your point, but the problem is that `sizeof(struct)` (without `packed`) depends also on the compiler. Yes. That is why we check for `sizeof(T)` to be smaller...
Still an issue here?
Right now the `contrib` folder only contains these two files, hidden. For new users (or developers not aware that we have a `clang-format` stylefile) it's virtually invisible...