Michael Lamers
Michael Lamers
This is a great idea! I will have a look when I have some time to spare. Thanks for this suggestion
> I took a closer look at v2.0.5 and this was not a breaking change from what I can see ([runtimeType was still considered in the equality check](https://github.com/felangel/equatable/blob/2117551ff3054f8edb1a58f63ffe1832a8d25623/lib/src/equatable_utils.dart#L25)). The new...
@felangel I digged deeper and found out why 2.0.6/2.0.7 breaks our code. The piece of code is not using the custom equality objects directly but they are in a list....
> Sorry for the delay (I was off for a lot of the holidays). Will try to get this merged later today or tomorrow 👍 No problem. We have a...
> @devmil - Widening the return type seems to be a minor breaking change at the moment - should it be a major breaking change instead? I agree. I created...
> @devmil - Widening the return type seems to be a minor breaking change at the moment - should it be a major breaking change instead? Widening the type already...
> Also, I thought `"type": "minor"` indicates that this warrants only a minor version change, or what does it mean? Ah, I see. The confusion comes probably from the fact...
> Sounds good - and the `version` key of the report should then also suggest `5.0.0`, correct? ['version']['needed'] should already contain that information today Edit: Looking at the generated comment...
> Yes, the `needed` field is [the one being parsed](https://github.com/dart-lang/ecosystem/blob/bed43c312bc22d0c6f86c6d32e00235314c2a460/pkgs/firehose/lib/src/health/health.dart#L195). So, the problem is that the old version is a pre-release version. In that case there is no major bump...
> Hm, that sounds like the API tool it is working correctly after all. > > The health PR check currently tests against the repository checkout, it's an interesting question...