label-maker icon indicating copy to clipboard operation
label-maker copied to clipboard

Not all labels for border tiles are downloaded

Open janpisl opened this issue 5 years ago • 4 comments

Perhaps it's best to explain my issue with a simple example:

  1. I set the bounding_box in config.json to [0,0, 100,100].
  2. I download labels within the bounding box
  3. I download tiles of size 20*20. One of the downloaded tiles is "Tile X" with coordinates [90,90, 110,110].
  4. In tile X, my model detects an "object O" at coords [105, 105, 106, 106].
  5. This object is however not in labels because it is outside of the bounding box set in config.json. So it seems like a "false positive" when actually the detection is correct.

Is this known/desired?

I imagine a functionality could be added that would check coordinates of tiles and then download all labels within the tiles.

janpisl avatar Aug 15 '20 14:08 janpisl

Thanks for the write-up and identification. I think the current behavior is not desired and the ideal functionality would be to use all labels within the downloaded tiles

drewbo avatar Aug 17 '20 13:08 drewbo

Sure! Let me know if I can help to fix this, I'd be happy to contribute.

janpisl avatar Aug 18 '20 20:08 janpisl

That would be great. I'm prepping a 0.9.0 release now (all of @martham93's recent work) and it will be easiest to branch off that shortly

drewbo avatar Aug 19 '20 14:08 drewbo

Hi, sorry I am currently swamped with other work so I am not sure when I find time for this.

janpisl avatar Sep 05 '20 19:09 janpisl