preact-markup icon indicating copy to clipboard operation
preact-markup copied to clipboard

Re-render markup when components prop changes

Open d3x7r0 opened this issue 6 years ago • 4 comments

Fix for issue #25: change the shouldComponentUpdate function to allow re-rendering when the components prop changes.

d3x7r0 avatar Jul 10 '19 12:07 d3x7r0

It's weird that Github isn't showing the easy "update" button - I fixed the test runner issue on master.

developit avatar Aug 06 '19 13:08 developit

I rebased with master anyway, that should get Travis running

d3x7r0 avatar Aug 06 '19 13:08 d3x7r0

Hey, can we get this merged? It would really help in my current project.

d3x7r0 avatar Aug 21 '19 09:08 d3x7r0

This PR looks like it could / should be merged? :)

I would just change this comment:

// one of the components changed:

...with:

// one of the components changed, or a new one was added:

(to more accurately describe the possible cases)

danielweck avatar Mar 30 '21 06:03 danielweck