mitt icon indicating copy to clipboard operation
mitt copied to clipboard

chore: fix typescript issue with `NodeNext`, fix #166

Open Mister-Hope opened this issue 3 years ago • 3 comments

Mister-Hope avatar Aug 24 '22 06:08 Mister-Hope

We might also need to lower the "typings" property as described in typescriptlang.org

diff --git a/node_modules/mitt/package.json b/node_modules/mitt/package.json
index ad38c7b..7649cc8 100644
--- a/node_modules/mitt/package.json
+++ b/node_modules/mitt/package.json
@@ -7,12 +7,13 @@
   "jsnext:main": "dist/mitt.mjs",
   "umd:main": "dist/mitt.umd.js",
   "source": "src/index.ts",
-  "typings": "index.d.ts",
   "exports": {
+    "types": "./index.d.ts",
     "import": "./dist/mitt.mjs",
     "require": "./dist/mitt.js",
     "default": "./dist/mitt.mjs"
   },
+  "typings": "index.d.ts",
   "scripts": {
     "test": "npm-run-all --silent typecheck lint mocha test-types",
     "mocha": "mocha test",

lbm98 avatar Aug 27 '22 22:08 lbm98

I did not remove typings field? Why are you mentioning that?

Edited: You might want to express that we need a typings property in exports, but that's UNNEEDED, as long as typescript cares about exports field, it already recognize types

Mister-Hope avatar Aug 28 '22 07:08 Mister-Hope

Hi, any update with this?

Mister-Hope avatar Sep 18 '22 03:09 Mister-Hope

Any update with this? @developit

Mister-Hope avatar Oct 18 '22 05:10 Mister-Hope

Thanks! Sorry about the delay.

developit avatar Oct 25 '22 02:10 developit

Any release schedule for this?

Mister-Hope avatar Oct 30 '22 11:10 Mister-Hope

Hi bro, we still need this fix to be published as 3.0.1

Mister-Hope avatar Nov 11 '22 05:11 Mister-Hope

hey @developit , is there a way to get this released?

marcoreni avatar Jan 17 '23 12:01 marcoreni

Hi @developit, we need v3.0.1

dgeibi avatar Jun 06 '23 10:06 dgeibi