karmatic icon indicating copy to clipboard operation
karmatic copied to clipboard

Make puppeteer an optional dependency

Open andrewiggins opened this issue 5 years ago • 1 comments
trafficstars

Continuing our discussion from #54 and slack, wanted to see what people think about this.

Pros:

  1. Reduces installation size and time of karmatic and its deps
  2. Still allows consumers to use puppeteer if they want

Cons:

  1. Assumes users already have Chrome installed
  2. Breaking change

Probably other thoughts I haven't considered.

I'm not personally attached to any approach (normal dep, peer dep, secret optional dep), but just wanted to get consensus before our next release. What do y'all think? @developit, @marvinhagemeister

andrewiggins avatar Aug 14 '20 19:08 andrewiggins

I think I still prefer peerDep, though perhaps I need to rethink that now that npm is installing those by default...

developit avatar Aug 14 '20 20:08 developit