karmatic
karmatic copied to clipboard
Make puppeteer an optional dependency
trafficstars
Continuing our discussion from #54 and slack, wanted to see what people think about this.
Pros:
- Reduces installation size and time of karmatic and its deps
- Still allows consumers to use puppeteer if they want
Cons:
- Assumes users already have Chrome installed
- Breaking change
Probably other thoughts I haven't considered.
I'm not personally attached to any approach (normal dep, peer dep, secret optional dep), but just wanted to get consensus before our next release. What do y'all think? @developit, @marvinhagemeister
I think I still prefer peerDep, though perhaps I need to rethink that now that npm is installing those by default...