Jason Miller

Results 1189 comments of Jason Miller

100% - I really want to add this. It's a tiny bit of a guessing game as to where in the HTML file WMR should inject the stylesheet, but "before...

I think this may be a regression caused by our recent upgrade of `@rollup/plugin-commonjs`.

@qjnz no other info really, just myself or someone else needs to figure out which [requireReturnsDefault](https://github.com/rollup/plugins/tree/master/packages/commonjs#requirereturnsdefault) and [esmExternals](https://github.com/rollup/plugins/tree/master/packages/commonjs#esmexternals) values we should be passing to `@rollup/plugin-commonjs`, since the values we're passing...

Yeah, it's around 500b larger for the two bundles in the example. Also since I replaced the usage of Terser with ESBuild in all build pipelines here, I've just noticed...

@davezuko It needs to be rebased a bit before we can do much of a comparison, and then I'd like to run it against a few development + production apps...

For those interested, here's the comparison of Terser VS ESBuild from back when I did this PR: https://gist.github.com/developit/ba6bfe0ccdb65254c850b3d3f26e938d

This would be nice, though both of those options would dramatically increase the on-disk size of Microbundle. Perhaps we could move to ESBuild at the same time as we ship...

Ah interesting - I think this could be solved by passing the changed file path through fs.realPath.

Alright, I finally chased this one down. It's a bug in styled-components, which uses a fairly old version of Rollup's commonjs plugin to generate its ESM bundles that is just...

Indeed - the misuse of named imports and over-reliance on webpack-specific compatibility workarounds is basically universal. If we can find a way to patch these broken modules in WMR, I'm...