Jason Miller
Jason Miller
Interesting that the numbers are still so increased. My guess is that's because we're ending up with a closure around the two top-level functions, whereas currently there is no closure...
Ahh, yeah this is an interesting point. We'll likely have to go back to the old defs...
@1999 I'm so sorry for never responding to your PR. If possible, do you think you could take a look at #117 and tell me if that would work with...
I still need to check if this is correct. We landed #117 but I don't have a TypeScript project to test things out in.
@stereobooster I'm kinda wondering if that piece is required to make this PR usable TBH. I love the idea of keeping things split up, but we should probably just make...
Another option would be to export AbortController separately: ```js import fetch from 'unfetch'; import AbortController from 'unfetch/AbortController'; ``` I've been thinking of doing the same for `Headers`, `Request` and `Response`.
@nfantone AbortController is pretty well-supported now, yes. At the time of this original discussion it was only supported in Chrome. I think now we can merge this - unfetch is...
I think the two issues addressed in #137 make it preferable here - AbortController should be usable across multiple fetch() calls, and it should really reject with a value, since...
This discussion makes me happy :) Let's keep this on a list of nice-to-haves that we can look to if we save bytes. Btw - for defaults, we should make...
Yup, a way to inject defaults by proxying window.fetch: ```js let real = window.fetch; window.fetch = (url, options) => { // Apply URL and options transforms here return old(url, ootions)...