Jason Miller

Results 1189 comments of Jason Miller

Interesting - we have a hook called `options. _catchError` - maybe this could be a replacement for that hook?

@Z2Y this happens because `SomeButtonItem` closes over `props.children`, which retains it. The issue is already fixed in Preact 11, where `props.children` is a pure JSX element with no tree structure:...

@Z2Y the workaround won't break anything, I only have it clearing properties that Preact ignores during unmounting. Your Set solution is good though, you could iterate over the properties of...

Is `isServer` the one for prerendering? I regret calling it "SSR" here haha

Yeah, SSR is a bit of a misnomer there. Unless folks are still abusing it for SSR? haha

I opened PRs to fix both issues.

That's a good idea - I couldn't figure out how to add one on the tutorial pages themselves because there's not much real-estate left there, but on the index page...

@JoviDeCroock good call, definitely worth getting those landed on 5.x.

It appears this is only an issue when `renderToStaticMarkup` is used directly from within a component that is currently being rendered by ReactDOM (see [working non-nested example](https://codesandbox.io/s/upbeat-sanderson-b0kn0l?file=/src/index.js)).