Jason Miller

Results 1189 comments of Jason Miller

Seems reasonable. What's the purpose? I'm curious if anyone was relying on the old context. Likely not..

You can add routes to the middleware after creation - it just returns an Express Router. https://expressjs.com/en/guide/routing.html Not sure if there is a way to add new verbs as paths...

Yup, that was what I was suggesting. The issue is that `resource-router-middleware` uses a mapping to figure out how to bind URLs for functions you pass it - for arbitrary...

Hmm - that is very strange.

^ awesome! We're actually looking at shipping a Jest-based testing setup with preact-cli, and it would support both `preact-jsx-chai` and `preact-render-spy`.

That import preserves component names and applies formatting to complex attribute values (prop values), including the ability to serialized JSX within props. I think we'll need to make the comparison...

Ah actually it looks like this is a bug that was recently introduced in `preact-render-to-string`. The following condition turns `` into ``, which is incorrect and breaks your comparison: https://github.com/developit/preact-render-to-string/blob/master/src/index.js#L161-L163

Hmm - not sure if there's a way to do that via `preact-jsx-chai`, though the underlying `preact-render-to-string/jsx` library has an option `{ renderRootComponent: true }` that does exactly what you...

Sorry for not seeing this! I think actually the first replacement (`this.__P`) should no longer be necessary in the latest version of Preact 10. The children one is definitely needed...

I can try to, though honestly I don't use this module at all. I'll tag this issue with Help Wanted, maybe some passerby will have great examples to point to.