Jason Miller

Results 1189 comments of Jason Miller

Just noticed the React docs seem to indicate they don't support componentDidCatch during SSR: https://reactjs.org/docs/error-boundaries.html Are we early on this and risking breaking compat?

One thing I think we might want to consider is extending this to also allow catching enqueued state updates. Something like "render the component, then check if it errored or...

This actually is an HTM issue. JSX converts html-encoded entities to UTF8 ([see example](https://babeljs.io/repl#?browsers=&build=&builtIns=false&spec=true&loose=false&code_lz=PTAEAECsGcA9QBYCgA8ATAlgNwHwENQAyPAWwAcBuUAIxWE1wqSA&debug=false&forceAllTransforms=false&shippedProposals=false&circleciRepo=&evaluate=false&fileSize=true&timeTravel=false&sourceType=module&lineWrap=true&presets=react&prettier=false&targets=&version=7.12.14&externalPlugins=)), it's not part of VDOM rendering. Because of this, `preact-render-to-string` is never passed `"a & b"`...

Looks good to me! Maybe we can get @ShalokShalom to review it as well :)

I should think so! Couple of minor conflicts to resolve but we should definitely get this out. @marvinhagemeister - think we're good to sign off on this?

Hi there! Preact has its own developer tools that you can install as a browser extension: https://preactjs.github.io/preact-devtools/ As for the "Why Did You Render" library, the reason there is no...

The left nav is actually a Table of Contents, and the button is at the bottom. I can see how this could be confusing though, @marvinhagemeister and I have talked...

Did you mean to close the issue @38elements? Definitely open to thinking about how we could make this clearer 😊 _**edit** also I just realized you wrote "hamburgler" and I...

@conorhastings That would be awesome - I've been pondering the best approach myself. Right now the renderer doesn't use an intermediary, so it's straight to string concat. I think the...