Jason Miller

Results 1189 comments of Jason Miller

@hiepxanh if the update doesn't add support for it, the only solution would be to intercept and compile/modify the selector before it gets passed to css-select.

Shouldn't be a workaround needed, since this is only a warning. It just means the generated critical CSS will not include the affected selector.

Thanks for the patch. I need to re-target this to a new branch that will track the 1.x line.

```js import undom from 'undom'; import {config as renderSpyConfig} from 'preact-render-spy'; let doc = undom(); renderSpyConfig.createFragment = () => doc.createElement('body'); ```

I was going to suggest `resolved()`! So to clarify - one method returns the component-resolved tree in a FindWrapper, the other returns the component-resolved tree as VNodes?

This is a good pattern. If it's useful to you, `preact` now exports `createElement()` (same as `h()`). That means all the major VDOM libs support `{ createElement, cloneElement, Component, render...

Just a note: because preact exports createElement in version 7+, you can do this: ```js import * as preact from 'preact' const theming = themingFactory(preact) const { withTheme, ThemeProvider }...

This is actually more of an EJS problem - ejs templates don't mix nicely with HTML. I don't have a great recomendation right now other than to avoid using this...

@idudinov that looks great. I'm almost tempted to try to migrate this project to be a plugin, or provide both flavors in one module. Thoughts?

Seems like to be a syntax error. What version of Node are you running?