Jason Miller

Results 1189 comments of Jason Miller

Ah - no, you're exactly right, I'd forgotten about the file extensions issue. Interesting approach with the multiple tsconfigs - that actually doesn't seem bad at all. Not sure why...

Might make sense to combine, or have `preact-markup` simply invoke `preact-html` under the hood (just wrapping it up in a component). Not sure!

This is going to inline jsdom in all bundlers. I think we'll need to provide a separate entry module for web/node in order to do the polyfilling.

It's weird that Github isn't showing the easy "update" button - I fixed the test runner issue on master.

Ah yeah that's a good point. This uses the browser's built-in DOM parser, which isn't available under node. Should be possible to detect node and require() in a simple parser...

@d3x7r0 it's an oversight, but I think if we want to add support for updating when the listing changes we'll need to deeply compare the object values within `props.components`: ```diff...

This library had originally been designed to work with either Preact or React, but the use of render arguments makes it Preact-specific. I'd be open to a PR to fix...

I think this makes sense for `preact-markdown` for sure, but the reason it's not the default is because not all browsers support HTML parsing properly. I'd be interested in finding...

something going wrong here: https://github.com/developit/preact-markup/blob/master/src/parse-markup.js#L61

@TroyAlford if you ping me via preact-slack.now.sh I'd be happy to chat - seems like we need to find a decent wrapper around DOMParser that normalizes those differences. FWIW the...