Jason Miller

Results 1189 comments of Jason Miller

Wouldn't it be better to have a single action calculate and size diffs for all files in the monorepo?

This would certainly be neat! It's a bit tricky to think how webpack-bundle-analyzer itself could be used, since this action has no knowledge of what build system is being used....

This is interesting. Other names I've seen used to casually refer to something along these lines are "Persistent Fragment" (given that it doesn't empty when appended) and just "Range Fragment"....

Hiya! Sorry for the delay here - I'm actually not sure about this one, since numeric properties are supported on objects it feels a little unsafe to infer arrays.

Arrays are just objects with numeric properties though - you can already use `nested.state.0.key` to access array indices.

Hey @martinholters! Sorry about the wait there - I read this but then forgot to come back to the tab. I like the approach and I think this is the...

You described what I meant perfectly, and agreed regarding it not really needing to be a polyfill. Shouldn't block merging based on that goal though, I'll re-review (sorry for the...

Hi @martinholters! This is a limitation of the polyfill, and one I'd love to overcome but as of yet haven't found a good solution for. Your timer-based version is novel,...

@jasonkuhrt most of the optimization still needs to be done at the app level, however many of the most valuable optimizations (dead code elimination, cross-module inlining, module splitting, etc) are...

TS can emit ESM, no need to change versions to get that. Just set the `{"module":"ESNext"}` in the "compilerOptions" section of `tsconfig.json`. To improve the output quality, you could set...