Jason Miller

Results 1189 comments of Jason Miller

I think a fair number of projects use this module, so it's not dead. I haven't needed to update it because I haven't been using Jest for quite a while,...

Not yet! I'd like to set up a test page that can be used to demonstrate which types of work are best suited to this technique. It could also be...

@JamesMilnerUK I took a look at the tests. Nice to have this data! I've got an open task to do exhaustive benchmarking of workers that I'll be diving into over...

What are you passing to `new Worker()`?

Ah - we'll need to have self.fetch in the worker context patch URLs it receives to rebase them.

Hi @eranimo. This does sound like a painful experience. Do you happen to have a way to create a minimal reproduction? My inclination would be to drop WorkerPlugin into a...

TBH I think I agree with your point about the cleaner fix @gluck - it'll break existing names, but perhaps that's okay? Could even append `.worker` to the name, then...

I think this looks good! I'll need a little bit before I can do a proper thorough review. We'll want to think about whether this constitutes a v5 or not...

Yikes - I didn't know about this removal, thanks for looking into this. I believe the following should work as a replacement for [the usage](https://github.com/GoogleChromeLabs/worker-plugin/blob/5021ef670558112974db7f55ae096629b627d17f/src/index.js#L117-L122), to support both Webpack 4...

FWIW Webpack 5 seems to have landed its own `worker-plugin`, which I guess means this plugin shouldn't be used with it.