Jason Miller

Results 1188 comments of Jason Miller
trafficstars

By the way, if you add me as a contributor on [babel-preset-preact](https://www.npmjs.com/package/babel-preset-preact) I'd be happy to publish a working version! ❤️

Webpack alias should take care of it. I'm releasing preact 8.0 today, I'll ping here and we should see if that fixes this issue.

^ it's out by the way! Let me know if you're still seeing an issue.

Hi @tconroy - sorry for the delay there. How are you rendering the child elements? (or binding them to the web components?) Is it a custom element with an `attachedCallback`...

I wonder if it's being cached.... if so only `attachedCallback` would be fired, not `createdCallback`. Thoughts?

Totally. Looks like that's directly related to the investigation @Nekr and myself were doing into removing component caching. I agree caching/recycling invalidates assumptions components could be making, particularly when they...

It will impact some silly benchmarks that remount identical components a million times. In the real world though, it will very likely be faster. Will absolutely be better for memory...

This is because mdl moves the element outside of Preact's knowledge. Super happy to discuss the issue, but at present I don't really have a workaround.

Hmm - it looks like `react-mdl` have a pretty specific fix for this that involves actually modifying the MDL source: https://github.com/react-mdl/react-mdl/commit/36b40dfb51eea887d5b1bdcb6ad21eb5f05f40a3 Discussion here: https://github.com/react-mdl/react-mdl/issues/143 Not sure why those wouldn't work...

This is still an issue. Switching to a WeakMap would likely help. I opened a PR with a basic implementation.