Jason Miller

Results 1188 comments of Jason Miller
trafficstars

This is really good, I've been hoping to get proper support for Material UI in for some time now. I think we can definitely add the `.persist()` modification to `preact-compat`....

Definitely have to go with #1 - synthetic events is one of the things that makes React larger than Preact. I think your first option is pretty good, and the...

Likely will have to use a proxy handler that does the type negotiation when the event is triggered. I agree though, my thinking was that a VNode Hook would work...

Will do, I'll loop you in on the PR!

I've been pondering this. I think actually all that is needed is to move [this line](https://github.com/developit/preact/blob/master/src/vdom/component.js#L52) into the `if (opts!==NO_RENDER)` block [here](https://github.com/developit/preact/blob/master/src/vdom/component.js#L50). Crazy?

@cia48621793 I just pushed the persist fix, but I'm wondering if adding `onTouchTap` will still not fix the issue - won't there still be a broken `react-dom/lib/` import?

@harshmaur the issue is that `inject-tap-event-plugin` is ridiculously unnecessary with preact-compat, but it relies on 5 internal libs from the react-dom package. We can fake out all the APIs as...

Wouldn't the `require('react-tap-event-plugin')` throw though? or are they specifying it as a `peerDependency` just to indicate that you (as the library consumer) need to have installed it?

I wonder - would it suffice to have a package that could be aliased in for `react-tap-event-plugin`? It could look something like this: ```js import { options } from 'preact';...

Plus this can be a separate package that might actually be useful beyond getting MUI working - anyone who wants basic FastClick style tap events could use it. Not as...