devdave

Results 15 comments of devdave
trafficstars

Went with dirt simple ``` def converter(self, meth): """ Decorator that assigns *meth* as the input converter. Returns *meth* unchanged. """ self.convert = meth return meth ``` Adjacent, I can't...

Obviously not a pull request but initial changes are here. https://github.com/devdave/attrs/tree/pr_240 Is there an ideal PR I can use as a guiding example of what I need to aim for...

@hynek That's not too big of a problem. Starting on refactoring; instance property `convert` to `_converter` (similar to `_validator`), though for the record I am still partial to convertor :)

All tests passing with changes to _CountingAttr, Attribute, and the init building logic https://github.com/devdave/attrs/blob/pr_240/src/attr/_make.py#L1183

I've tried to inflate the import data in the URL but unfortunately I don't have the right version of nodejs available.