cli icon indicating copy to clipboard operation
cli copied to clipboard

Read from docker credential helpers when fetching Features/Templates

Open joshspicer opened this issue 2 years ago • 2 comments

We should also support Docker credential helpers, these are more common in local setups. I recently figured out how to use them for the Dev Containers extension. The code will need to be adapted, it implements a credential helper proxy: https://github.com/microsoft/vscode-remote-containers/blob/main/src/common/dockerCredentialHelper.ts

Originally posted by @chrmarti in https://github.com/devcontainers/cli/pull/341#discussion_r1059309278

joshspicer avatar Dec 31 '22 20:12 joshspicer

Reported in https://github.com/devcontainers/features/issues/376

samruddhikhandale avatar Jan 06 '23 17:01 samruddhikhandale

It seems like docker's credential helper is no longer injecting the credsStore entry into the .docker/config.json

I think this task is still valid (to support Docker's credential helper) - but at least by default it is no longer getting injected into their config.json

ghost avatar Jan 22 '23 03:01 ghost

Fixed with https://github.com/devcontainers/cli/pull/460.

chrmarti avatar Jan 07 '25 22:01 chrmarti