remix-saas icon indicating copy to clipboard operation
remix-saas copied to clipboard

Published 20 hours ago • verified publisher icon dev-xo

[ Chore ] Move server to .ts

Open kewinzaq1 opened this issue 1 year ago • 5 comments

kewinzaq1 avatar May 12 '24 13:05 kewinzaq1

Hello @kewinzaq1, I appreciate the efforts and the Pull Request.

Could you explain where you got the references for the implementation, or the steps of it?

  • I will review the pull request, clean it a bit, and this will probably be a merge.

Solves: #232

dev-xo avatar May 12 '24 15:05 dev-xo

Hello @kewinzaq1, I appreciate the efforts and the Pull Request.

Could you explain where you got the references for the implementation, or the steps of it?

  • I will review the pull request, clean it a bit, and this will probably be a merge.

Solves: #232

Hello @kewinzaq1, I appreciate the efforts and the Pull Request.

Could you explain where you got the references for the implementation, or the steps of it?

  • I will review the pull request, clean it a bit, and this will probably be a merge.

Solves: #232

HI @dev-xo I did it based on The Epic Stack https://github.com/epicweb-dev/epic-stack

kewinzaq1 avatar May 12 '24 16:05 kewinzaq1

This is about to be merged @kewinzaq1.

  • Do you know if any of these changes will impact deployment somehow? In case we should update something else.

dev-xo avatar May 13 '24 21:05 dev-xo

Made a first deployment attempt. Although everything seems to work as expected in terms of deployment, the server is not able to initialize the app, and not sure why, as the run command has not changed.

Will give it another try later, in order to recheck this.

  • Will also try to deploy the main repo without this PR's effects.

Moved execa to dependencies, instead of devDependencies (in a private repository), in the same way Epic Stack seems to have it configured.

  • After deployment, this still doesn't seem to work either.

Leaving this PR open, as probably someone else will be curious about it, and we can keep discussing it, looking for a fix or for ways to handle this.

dev-xo avatar May 14 '24 21:05 dev-xo

Made a first deployment attempt. Although everything seems to work as expected in terms of deployment, the server is not able to initialize the app, and not sure why, as the run command has not changed.

Will give it another try later, in order to recheck this.

  • Will also try to deploy the main repo without this PR's effects.

Moved execa to dependencies, instead of devDependencies (in a private repository), in the same way Epic Stack seems to have it configured.

  • After deployment, this still doesn't seem to work either.

Leaving this PR open, as probably someone else will be curious about it, and we can keep discussing it, looking for a fix or for ways to handle this.

Thanks for the information. I'll check this

kewinzaq1 avatar May 16 '24 09:05 kewinzaq1