remix-saas icon indicating copy to clipboard operation
remix-saas copied to clipboard

[ Request ] Add Playwright Testing

Open HananoshikaYomaru opened this issue 1 year ago • 3 comments

refer to :

  1. https://github.com/sergiodxa/remix-auth/blob/main/test/authorizers.test.ts
  2. https://github.com/sergiodxa/remix-auth/discussions/166

HananoshikaYomaru avatar May 10 '24 17:05 HananoshikaYomaru

Hello @HananoshikaYomaru.

I noticed you also commented on #232. It would have been great if you could have referred to that issue here.

Currently, I'm a bit busy, so I'm not sure if I will be available to look into this right now.

  • Why do you need to test the authentication? (That's already well-tested by remix-auth-totp).
  • Any special case you are looking for?

Thanks.

dev-xo avatar May 10 '24 17:05 dev-xo

it is not to test the authentication library. it is to test my system authentication is done correctly. For example I want to test the login flow using playwright ui mode. I also want to test features that require authentication and make sure auth protection are working now and in the future (regression testing), in case of me accidentially remove the auth or do some stupid thing etc.

HananoshikaYomaru avatar May 10 '24 18:05 HananoshikaYomaru

It's hard to know what you're looking for without a proper explanation of the issue, @HananoshikaYomaru.

Please take your time to explain exactly what you're looking for. For example:

  • It would be great to add Playwright Testing because...
  • My use case for it would be...

We can't understand the issue without a proper explanation. You're also referencing two links that don't explain your current issue but instead show some examples.

  • Also, one of the links is Cypress-related, and you are asking for Playwright apparently.

Thanks.

dev-xo avatar May 10 '24 18:05 dev-xo