Ensure that ssh is installed (cf #771)

[Byh0ki]

As discussed in https://github.com/dev-sec/ansible-collection-hardening/pull/771, this MR ensure that SSH is installed

[rndmh3ro]

@Byh0ki, some tests fail, do you want to take a look?

[Byh0ki]

Yes, I'll try to fix that before the end of the week.

[Byh0ki]

I've modified a little bit the vars, it should fix most of the failed actions but I' not sure about the OpenBSB fail

[Byh0ki]

The specific vars were not applied, I've modified the behavior. For FreeBSD, it seems that the packages db is empty in the molecule test which we can't do much about :/

[Byh0ki]

@rndmh3ro, after a few tries, everything seems to pass the tests except FreeBSD12 and OpenBSD7. I don't know these OS very well so I don't know how to fix the issue with those :/ Do you know if anyone can help on that?

[rndmh3ro]

Thank you! We'll need to check what's wrong with the BSDs.

[schurzi]

I suspect he problem with FreeBSD 12 is that it's now out of support and the mirrors changed. Will have to look into OpenBSD, but that one is always special ...

[schurzi]

I created a PR to remove FreeBSD12 https://github.com/dev-sec/ansible-collection-hardening/pull/777

The problem with OpenBSD is rooted in changes in this PR and need to be addressed. As far as I can find information on it OpenBSD has no separate SSH package since it is bundled with the base system. So leaving the variable ssh_pkgs empty might be an option here.

[Byh0ki]

Seems good enough for me, I'll update the PR for OpenBSD.

[Byh0ki]

Perfect, when the FreeBSD 12 PR is merged, everything will be green

[Byh0ki]

Nice! Thank you, do you have a plan to release a new version soon?