derivepass-vue icon indicating copy to clipboard operation
derivepass-vue copied to clipboard

Application: add button to show password

Open Fishrock123 opened this issue 5 years ago • 6 comments

This is very useful for manually entering passwords into devices that are unable to access derivepass.

Also fixes a silly warning display bug.

Screen Shot 2020-01-06 at 6 03 27 PM Screen Shot 2020-01-06 at 6 03 33 PM

I suppose I could add more space between the buttons... I'm not sure how best to do so without making something custom though. Something about margins and negation via :first-child and :last-child...

Fishrock123 avatar Jan 06 '20 23:01 Fishrock123

This pull request is being automatically deployed with ZEIT Now (learn more). To see the status of your deployment, click below or on the icon next to each commit.

vercel[bot] avatar Jan 06 '20 23:01 vercel[bot]

Great idea! I needed this myself many times.

Do you think it might be better to hide it in "Edit" so that the user won't accidentally reveal the password? Or should there be a confirmation?

indutny avatar Jan 08 '20 17:01 indutny

Yeah I wasn't quite sure either. An extra confirmation could be good, I suppose.

Fishrock123 avatar Jan 08 '20 17:01 Fishrock123

What about using a button group for those buttons?

elboletaire avatar Jan 16 '20 23:01 elboletaire

I'm not very familiar with Vue. I'll take a look soon.

Fishrock123 avatar Jan 29 '20 22:01 Fishrock123

I'm talking about the bootstrap's button group component: https://getbootstrap.com/docs/4.3/components/button-group/

elboletaire avatar Jan 30 '20 01:01 elboletaire