python-nameparser icon indicating copy to clipboard operation
python-nameparser copied to clipboard

Enhance nickname processing

Open aikimark opened this issue 4 years ago • 2 comments

  • converted REGEXES from set() to list
  • added optional label/tag to regex tuples
  • created new self variable for nickname regexes
  • changed nickname processing logic
  • added tests for nicknames, including adding patterns and multiple nicknames

aikimark avatar Mar 22 '21 18:03 aikimark

I have responded via email.

Should I copy my response into the textboxes above? This is my first pull request.

aikimark avatar May 05 '21 01:05 aikimark

I think if you respond in the github UI it just facilitates the conversations about comment. I will take a closer look at your email later tonight.

  • Derek Gulbranson

On May 4, 2021, at 6:37 PM, aikimark @.***> wrote:

 I have responded via email.

Should I copy my response into the textboxes above? This is my first pull request.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

derek73 avatar May 05 '21 18:05 derek73