cauldron
cauldron copied to clipboard
Font weight epic
Tasks
In reviewing some UI recently with @bobbyomari, he noticed some issues with our font-weight
- [ ] drop support for
var(--font-weight-thin)as it is unused (this will be a BREAKING CHANGE for any cauldron consumers who rely on this var) - [ ] drop support for
var(--font-weight-light)as it is unused (this will be a BREAKING CHANGE for any cauldron consumers who rely on this var)- [ ] no longer need to import it either
- [ ] button's font-weight should be set to
var(--font-weight-medium)
For clarity, the font-weights are as followed:
- font-weight: 400 = regular
- font-weight: 500 = medium
- font-weight: 700 = bold
Best practices is to use the numerical value and not the words 😄
drop support for var(--font-weight-thin) as it is unused (this will be a BREAKING CHANGE for any cauldron consumers who rely on this var)
It is used in one spot: https://github.com/dequelabs/cauldron/blob/f7af2061c4314f69641af80c9f5bfffee8399f74/packages/styles/forms.css#L224
Am I assuming correctly that we're updating the font weight here with this proposed change?
I additionally found other usages of font-weight-light as well.
We can update the usages of this, but should not remove the variables until we decide we want to release a breaking change.