cauldron icon indicating copy to clipboard operation
cauldron copied to clipboard

Font weight epic

Open schne324 opened this issue 2 years ago • 4 comments

Tasks

In reviewing some UI recently with @bobbyomari, he noticed some issues with our font-weight

schne324 avatar Jan 18 '23 18:01 schne324

For clarity, the font-weights are as followed:

  • font-weight: 400 = regular
  • font-weight: 500 = medium
  • font-weight: 700 = bold

Best practices is to use the numerical value and not the words 😄

bobbyomari avatar Jan 18 '23 19:01 bobbyomari

drop support for var(--font-weight-thin) as it is unused (this will be a BREAKING CHANGE for any cauldron consumers who rely on this var)

It is used in one spot: https://github.com/dequelabs/cauldron/blob/f7af2061c4314f69641af80c9f5bfffee8399f74/packages/styles/forms.css#L224

Am I assuming correctly that we're updating the font weight here with this proposed change?

scurker avatar Feb 02 '23 21:02 scurker

I additionally found other usages of font-weight-light as well.

scurker avatar Feb 02 '23 21:02 scurker

We can update the usages of this, but should not remove the variables until we decide we want to release a breaking change.

scurker avatar Feb 21 '23 19:02 scurker