pandas-vet icon indicating copy to clipboard operation
pandas-vet copied to clipboard

Add nox

Open dat-boris opened this issue 5 years ago • 3 comments

This PR add the nox as a starting environment for getting started with pandas-vet.

Issue: #86

Changes:

  • [x] Adding initial nox infrastructure
  • [x] Edit README to reflect new nox setup
  • [ ] Test with different version of python (e.g. 3.5) to ensure nothing breaks

dat-boris avatar Feb 11 '20 00:02 dat-boris

This is working well now

$ nox

image

One thing is that I'm still experimenting with how to use multiple python version - currently, when I add multiple pyversion it will not work and require adding pyenv install manually. This is probably not the experience we want.

I will take a further look at how to make multiple version of python works / if it makes sense.

dat-boris avatar Feb 11 '20 01:02 dat-boris

I'm not sure if you're still working on this, but from my experience configuring multiple Python versions is tricky and OS-specific. You can likely leave up that part of the configuration to the developer and document a few recommended options. For example, on Windows (if not using wsl), the best option right now seems to be conda (miniconda or full anaconda). I am hopeful for pyenv-win, but https://github.com/pyenv-win/pyenv-win/issues/204 needs to be resolved. For Mac/Linux, pyenv seems to be the most common, but conda can also be used. Given that pandas-vet is for the datascience/pandas community, a lot of people might already have conda installed. And of course you can just manually install multiple Python versions on any OS

KyleKing avatar Feb 10 '21 16:02 KyleKing

Ha @KyleKing thanks for the reminder! I am not working on this at the moment.

It is good that PyCascade 2021 is coming soon!

I'm not sure if you're still working on this, but from my experience configuring multiple Python versions is tricky and OS-specific. You can likely leave up that part of the configuration to the developer and document a few recommended options. For example, on Windows (if not using wsl), the best option right now seems to be conda

The motivation of using nox is to enable better testing of multiple python versions. It alleviate the pain point of having to manually run test on multiple version of python (which you have to do manually even with environment managers available).

Nox should be able to use different environment manager you mentioned - for example, nox does support using conda underneath -https://nox.thea.codes/en/stable/tutorial.html#testing-with-conda.

And saying that I am not actively working on this at the moment. If you or other participating in the PyCascade sprint would like to work on this, welcome to take over 🤗

dat-boris avatar Feb 11 '21 03:02 dat-boris