ale icon indicating copy to clipboard operation
ale copied to clipboard

fix(eslint): handle monorepo setup for eslint

Open bodymindarts opened this issue 2 years ago • 3 comments
trafficstars

The heuristic for finding the correct Cwd when executing eslint does not work in the context of a monorepo setup where the .eslintrc.js may not live in the root of the repo but in one of the leaf packages ie. each package may have its own settings.

This PR fixes the behaviour by setting Cwd to the closest config path instead of the bin path.

Fixes https://github.com/dense-analysis/ale/issues/4487

bodymindarts avatar Oct 19 '23 19:10 bodymindarts

I'll have a think about this. ESLint keeps changing over the years and this change could break something.

w0rp avatar Oct 23 '23 18:10 w0rp

This looks like the correct behaviour to me. You'll have to fix the tests. See :help ale-dev.

w0rp avatar Dec 10 '23 11:12 w0rp

This pull request has been automatically marked as stale because it has not been updated recently. Make sure to write tests and document your changes. See :help ale-dev for information on writing tests. If your pull request is good to merge, bother w0rp or another maintainer again, and get them to merge it.

stale[bot] avatar Mar 17 '24 10:03 stale[bot]