deploy_feedback
deploy_feedback copied to clipboard
denoland
What Compile Error Blocked Deploy?
When I push to master and didn't see my code deployed I thought Deno Deploy was broken.
I later discovered that a compile error silently blocked the deploy. Is there a better place to look next time this happens? Could there be a place that is hard to miss?
Aside: This happened while demoing your awesome product to a fellow engineer. I was stumped because my expectations were so high. He wasn't so encumbered, applied a little divide-and-conquer, found the mistake and remained impressed.
Compile errors should result in the GitHub status showing a ❌ instead of a ✅ . The compile error message will be added as a comment to the commit. Here is an example:
https://github.com/lucacasonato/fetchevent_examples/commit/e15e6692fb5fc48eb330a836efbc4e9e516b0e72
In a PR this will show up inline in the PR view:
https://github.com/lucacasonato/fetchevent_examples/pull/3
Do you have specific ideas on how we can improve this?
I do agree though, it'd be nice to be able to see the failing status from the Deploy dashboard and link to the action run from there, @lucacasonato wdyt?
Overly confident in our cut-and-paste ability we went straight to the project page. The tip off that would have saved us is if an additional row were added to the Preview Deployments table with an error message where one would expect a link to a deployment. With the commit linked right there I would have been fixing within seconds. (Pros that we are, we instead downloaded deployctl and started debugging closer to home.)
@lucacasonato I ran into a case where the deploy failed but no error comment was added to the commit.
Potentially relevant detail is that the repo is private? But in the Deno Deploy Github app everything seems to be configured correctly.
Click on the little red "X" in the top left. The error message should be visible there.
Thanks for the quick reply. I can't read it fully because it gets truncated 😕 EDIT: I managed to get the message from the github api haha, I'd still prefer a commit message
Hi @WardCunningham and @ttogola, we have added failed deployments to the deployments list, together with the error message, and the ability to see the build logs of all deployments. All this will be available going forward for new deployments (no retrofitting). I believe this covers all the feedback provided in this issue, right? I'm closing now, but feel free to reopen if you want to elaborate further.
