deno_lint icon indicating copy to clipboard operation
deno_lint copied to clipboard

missing recommended rules

Open mvolkmann opened this issue 4 years ago • 4 comments

The description says "Supports recommended set of rules from ESLint and @typescript-eslint out of the box with no config." It seems it does implement all the eslint:recommended rules, but only some of the plugin:@typescript-eslint/recommended rules. For example, I think the following rules are missing:

await-thenable, explicit-module-boundary-types, no-floating-promises, no-for-in-array, no-non-null-asserted-optional-chain, no-non-null-assertion, no-unnecessary-type-assertion, no-unsafe-assignment, no-unsafe-call, no-unsafe-member-access, no-unsafe-return, no-var-requires, prefer-regexp-exec, restrict-plus-operands, restrict-template-expressions, triple-slash-reference, unbound-method, no-empty-function, no-implied-eval, and no-unused-vars.

Maybe the description should be changed to say that it implements "many" of the typescript-eslint/recommended rules.

mvolkmann avatar Dec 04 '20 12:12 mvolkmann

@mvolkmann could you link to relevant configuration in typescript-eslint that lists these rules as recommended? Last time I checked I did not see most of them in recommended set.

bartlomieju avatar Dec 04 '20 12:12 bartlomieju

https://www.npmjs.com/package/@typescript-eslint/eslint-plugin#supported-rules

mvolkmann avatar Dec 04 '20 14:12 mvolkmann

@mvolkmann it seems the rules you've enumerated require type checking to enforce, which deno_lint can't do at the moment: #303, #270

bartlomieju avatar Dec 04 '20 14:12 bartlomieju

The linked npmjs seems to not available anymore. Here's a new link: https://typescript-eslint.io/rules/?supported-rules=recommended.

Anutrix avatar Sep 01 '23 23:09 Anutrix