deno_core icon indicating copy to clipboard operation
deno_core copied to clipboard

feat: `remove_es_module`

Open gearonixx opened this issue 1 year ago • 2 comments

Related issue: https://github.com/denoland/deno_core/issues/885 Example usage: https://github.com/kurtexdev/kurtex/blob/main/crates/kurtex_core/src/deno/runtime.rs#L110

Look at the tests to understand in more detail what the functionality is about. The point is to update existing V8 modules with the old JsRuntime instance, without creating new ones.

Made for local purposes. But if you have any ideas, let me know, and I'll finish this PR.

gearonixx avatar Aug 29 '24 09:08 gearonixx

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Aug 29 '24 09:08 CLAassistant

Codecov Report

Attention: Patch coverage is 96.01770% with 9 lines in your changes missing coverage. Please review.

Project coverage is 82.02%. Comparing base (0c7f83e) to head (4b86793). Report is 316 commits behind head on main.

Files with missing lines Patch % Lines
core/modules/module_map_data.rs 74.28% 9 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #890      +/-   ##
==========================================
+ Coverage   81.43%   82.02%   +0.58%     
==========================================
  Files          97       98       +1     
  Lines       23877    25155    +1278     
==========================================
+ Hits        19445    20634    +1189     
- Misses       4432     4521      +89     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov-commenter avatar Aug 29 '24 09:08 codecov-commenter