deno_core icon indicating copy to clipboard operation
deno_core copied to clipboard

Op re-entrancy guard is too wide

Open mmastrac opened this issue 1 year ago • 1 comments

Ideally the re-entrancy guard should only protect the op call itself, not the surrounding error-handling code that is out of control of the op writer.

mmastrac avatar Feb 01 '24 18:02 mmastrac

I was actually wondering about this when I saw the error message caused by a custom op invoking the op_is_native_error built-in.

Unexpectedly panicked!: op op_sign_ecdsa was not marked as #[op2(reentrant)], but re-entrantly invoked op op_is_native_error

mlafeldt avatar May 06 '24 11:05 mlafeldt