Doug Engert

Results 581 comments of Doug Engert

Will fix later today. On Wed, Sep 2, 2020, 9:05 AM Jakub Jelen wrote: > Additionally, I am getting crash with old PIV card: > > Thread 1 "lt-pkcs11-tool" received...

I will have a look at sm/iso-sm.h. It looks like it should work. This may take some time.

Pushing squashed and forced rebased version of this PR as it has become quite out of date. it will be used to address https://github.com/OpenSC/OpenSC/pull/2053#discussion_r531308092 and https://github.com/OpenSC/OpenSC/pull/2053#issuecomment-734908332 and to work with...

Good to hear they have new set of cards. [nist-special-database-33](https://www.nist.gov/srd/nist-special-database-33) was last "Updated March 23, 2021". It links to: [nist-piv-test-cards](https://csrc.nist.gov/projects/piv/nist-piv-test-cards) Updated August 13, 2021 and has a link to [email protected]...

As I think I said before, [NIST 800-73-4](https://nvlpubs.nist.gov/nistpubs/SpecialPublications/NIST.SP.800-73-4.pdf) is the Authoritative reference for PIV. The abstract in Part 2 goes on to state: "The goals are addressed by specifying a...

@frankmorgner we have a lot of disagreements about the size, complexity of code, especially the PIV code and support for multiple applets on cards. You don't like #2053 because it...

If not on card no way to know if private key exists. On Wed, Nov 10, 2021, 7:33 AM Frank Morgner ***@***.***> wrote: > ***@***.**** commented on this pull request....

@frankmorgner thanks for looking at the code closer. I will be addressing most of the comment above from the "I want to move forward with this so I took a...

@Jakuje. I don't know how I missed the August 21, 2020 comments. I believe I have fixed or commented on all you comments or they are now listed as outdated,...

@frankmorgner You asked on 11/22/21 https://github.com/OpenSC/OpenSC/pull/2053#discussion_r754706664 > Sure, I have read the code and the spec. The idea was to make the code more readable and to avoid piv_inc(). size_t...