charts icon indicating copy to clipboard operation
charts copied to clipboard

Add ability to configure `dnsPolicy`

Open judahrand opened this issue 1 year ago • 1 comments
trafficstars

According to Kubernetes' documentation the dnsPolicy should be set to ClusterFirstWithHostNet when hostNetwork: true is set. This PR adds the option to configure dnsPolicy for both node and controller parts of the Helm chart.

This solves an issue I was facing where a host was resolved by the controller (and so the NFS mount was configured) but was not resolved when the volume was mounted.

This is what csi-driver-nfs does: https://github.com/kubernetes-csi/csi-driver-nfs/blob/096163569b792c4eb38fcf652e8ef2c3a8a5060b/charts/v4.9.0/csi-driver-nfs/values.yaml#L102

judahrand avatar Sep 17 '24 19:09 judahrand

Hi! Thanks for the contribution. Just bump the version of the chart and we can merge. A patch version bump should be fine for this change.

travisghansen avatar Sep 29 '24 00:09 travisghansen