dockerfiles icon indicating copy to clipboard operation
dockerfiles copied to clipboard

add weasyprint docker image v1.0.0

Open SteveKeller opened this issue 6 months ago • 3 comments

Status

Ready

Description

Adding new python docker container image v1.0.0 with weasyprint v. for improved PDF report capability in XSOAR.

Versions

WeasyPrint version: 65.1 Python version: 3.12.8 Pydyf version: 0.11.0 Pango version: 14602

SteveKeller avatar May 15 '25 11:05 SteveKeller

Thanks for opening your first pull request. You are awesome!

Questions about how we build Docker images? Make sure to checkout our README.

What happens next?

  • The CI will run the build cycle on any new/modified docker images. If the build fails make sure to review the posted comment and address the errors.
  • Once the build passes, The CI will create a development docker image which can be used for local testing. A comment with the details will be posted to this PR.
  • A member of the team will then review the pull request.
  • If all is good and both the build is passing and the pull request has passed review, you will be able to merge the PR.
  • Once merged, The CI will run another build and create a production ready docker image which will be deployed at Docker Hub under the demisto organization: https://hub.docker.com/u/demisto .

Good luck to us all!

welcome[bot] avatar May 15 '25 11:05 welcome[bot]

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar May 15 '25 11:05 CLAassistant

can you share the related demisto/content PR? @JudahSchwartz @yaakovpraisler FYI

dantavori avatar May 27 '25 07:05 dantavori

closing due to inactivity. if still relevant, please explain the need and attach a relevant demisto/content PR.

dantavori avatar Jun 08 '25 10:06 dantavori

@dantavori can you reopen this PR. Did not got merged and I am still waiting.

SteveKeller avatar Jun 08 '25 11:06 SteveKeller

It wasn't merged because we are waiting for your response :)

dantavori avatar Jun 08 '25 11:06 dantavori

@dantavori what do you need?

SteveKeller avatar Jun 08 '25 11:06 SteveKeller

Where is it going to be used? Please attach a relevant demisto/content PR

dantavori avatar Jun 08 '25 11:06 dantavori

No related demisto/content. Just an additional docker image for Python scripts.

SteveKeller avatar Jun 08 '25 11:06 SteveKeller

Why do you need to contribute it to dockerfiles? We add Docker images to this repo when we want them to be used by the community. Without a corresponding script, how do you imagine the community would use it?

dantavori avatar Jun 08 '25 11:06 dantavori

My first attempts with building docker image locally and private image registry went well (no errors), but I could not get it to work in XSOAR Script. There are no information available how to debug docker images in XSOAR SaaS version 8, so I assumed my custom docker images need to go through your CI/CD pipeline to be working for SaaS. That's why I created this pull request just for the docker image without PR in demisto/content.

SteveKeller avatar Jun 10 '25 09:06 SteveKeller

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs.

If you'd like to keep it open, please leave a comment with the status of the PR.

Thank you for your contribution!

stale[bot] avatar Jun 24 '25 20:06 stale[bot]

This pull request has been automatically closed because there has been no activity for 21 days.

Please feel free to reopen it (or open a new one) if the proposed change is still appropriate.

Thank you for your contribution!

stale[bot] avatar Jul 01 '25 21:07 stale[bot]