content
content copied to clipboard
[New Pack] Google Gemini Content Pack
Contributing to Cortex XSOAR Content
Make sure to register your contribution by filling the contribution registration form
The Pull Request will be reviewed only after the contribution registration form is filled.
Status
- [ ] In Progress
- [x] Ready
- [ ] In Hold - ()
Related Issues
fixes: link to the issue
Description
This merge request introduces a new Google Gemini Integration for XSOAR, enabling AI-powered analysis and chat capabilities through Google's advanced large language models.
Key Capabilities
- Configurable Parameters: Temperature control (0.0-1.0), max tokens (1-10000), model selection
- Conversation History: Maintains context through JSON-formatted conversation history
- Flexible Configuration: Customizable API endpoint, SSL verification, proxy support
- Security: Secure API key authentication
Must have
- [x] Tests
- [x] Documentation
Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @ilappe will know the proposed changes are ready to be reviewed. For your convenience, here is a link to the contributions SLAs document.
Hi @warm200, thanks for contributing to the XSOAR marketplace. To receive credit for your generous contribution please follow this link.
This is a community pack, not partner
Hi @warm200 thanks for your contribution!
Since we intend to adopt your contribution and support this new pack as part of our XSOAR supported packs the review may take a while because we will need to implement our standards and processes. thanks!
@ilappe thanks for replying, totally fine with that. Meanwhile i'll take look at the pre-commit message and submit the fix
@ilappe updated the code, please rerun the pipeline when you got chance. thanks!
Hi @warm200 thanks for your effort i'm on it
In the meantime, I added the label docs-approved.
Thanks for code review, i'll address them as soon as possible
Thanks for code review, i'll address them as soon as possible
Thanks a lot @warm200 !! in addition XSOAR supported packs should follow XSOAR code and documentation conventions, and add unit tests (already here :) )and a test-playbook to test your code. For more information see XSOAR Code Conventions, XSOAR Packs Documentation, Unit-Testing, Test-Playbooks. Would you be able to make the necessary adjustments to ensure alignment with our standards?
Please don't hesitate to reach out with any queries or concerns; we're here to assist you every step of the way.
@ilappe thanks for the reminder. I'll review the doc you provided and make adjustment as well
hey @ilappe I addressed your code comment review in the last commit, please let me know if anything needs to be changed thanks
@ilappe any reason that the test playbook can not be found by the ci/cd pipeline? I referred other pack they just put the filename without the playbook- prefix.
@ilappe any reason that the test playbook can not be found by the ci/cd pipeline? I referred other pack they just put the filename without the playbook- prefix.
Hi @warm200
Thanks for your effort!
please revert the change to Tests/conf.json as i will make it in the internal PR
and please make a squash for the commits to avoid the CLA issue here
i'm reviewing the rest
thanks again!
hi @ilappe thanks again for the review. I have resolved all the comments and doc reviews. please check again!
why the reviewers list are bigger and bigger lol..
Thanks @warm200 for your effor!! can you please go over the pre commit errors thanks in advance!
@ilappe do i need to care about this error, doesn't seem it's telling me anything
@ilappe fixed except for the xsoar-lint, if you could trigger the pre-commit again, thanks!!
@ilappe fixed except for the xsoar-lint, if you could trigger the pre-commit again, thanks!!
Hi @warm200 Thanks for your efforts! i will handle the remain pre-commits. So we're ready for a demo. Please check this page, and let me know when you're available for one over DFIR. Feel free also to send me a recording of a demo.
@ilappe thanks! what's DFIR? ~is there a example of demo video I can refer to~found one from merged MR, will record a video soon!
@ilappe here is the demo let me know if you have questions
@ilappe thanks for the suggestions, please kindly review the code changes, added save_conversation flag with passing history into new conversation capablity. let me know if you have any questions
Thanks @warm200 for your effort looks good i will take it from here, and in the internal PR i will make few minor changes thanks a lot!
Thank you for your contribution. Your external PR has been merged and the changes are now included in an internal PR for further review. The internal PR will be merged to the master branch within 3 business days.