content
content copied to clipboard
Fix Cisco AMP endpoint command
Original External PR
Contributor
@lehrbaumm
Fixing an error in the endpoint command implementation for Cisco AMP. When the IP argument is used with multiple values, only the last response is returned.
Contributing to Cortex XSOAR Content
Make sure to register your contribution by filling the contribution registration form
The Pull Request will be reviewed only after the contribution registration form is filled.
Status
- [ ] In Progress
- [x] Ready
- [ ] In Hold - (Reason for hold)
Related Issues
Description
I fix a simple mistake in the implementation for the AMPv2 integration. Where not all results for the endpoint command with IP addresses are correctly collected. I also fixed it in the outdated Pack because it is where the mistake originated from.
Must have
- [ ] Tests
- [ ] Documentation
Coverage Report
File Stmts Miss Cover Missing Packs/AMP/Integrations/AMPv2 AMPv2.py 880 136 84% 1231, 1235, 1307–1308, 1310–1312, 1314, 1316, 1385, 1509, 1605, 1746, 1788, 1790–1791, 1794, 1898, 1960, 1991–1992, 1995, 1997, 1999–2000, 2005, 2007, 2019, 2022, 2025, 2071, 2074, 2237, 2299, 2367, 2452, 2687, 2767, 2919, 2963–2965, 2967–2968, 2970, 2972–2974, 2976, 2978–2980, 2982, 2985, 2987, 2989–2990, 2992–2993, 2995–2996, 3007–3008, 3010, 3019, 3043, 3050–3051, 3053, 3063–3065, 3067–3072, 3074, 3084–3085, 3087–3088, 3158, 3163–3166, 3219, 3327, 3330, 3362, 3365, 3461, 3555, 3583–3585, 3587–3593, 3595–3596, 3598, 3600, 3633, 3635–3636, 3646–3647, 3649–3653, 3655–3656, 3658–3659, 3661–3662, 3664–3665, 3674–3676, 3678–3679, 3682, 3684–3686 TOTAL 880 136 84%
| Tests | Skipped | Failures | Errors | Time |
|---|---|---|---|---|
| 54 | 0 :zzz: | 0 :x: | 0 :fire: | 3.544s :stopwatch: |
Validate summary
Verdict: PR can be force merged from validate perspective? ✅