content
content copied to clipboard
ANYRUN - Add win 11 support and privacy option
Contributing to Cortex XSOAR Content
Make sure to register your contribution by filling the contribution registration form
The Pull Request will be reviewed only after the contribution registration form is filled.
Status
- [ ] In Progress
- [x] Ready
- [ ] In Hold - (Reason for hold)
Related Issues
None, adds win11 support & byteam privacy option. See API documentation
Description
I just added the options and updated the README accordingly.
Must have
- [ ] Tests
- [x] Documentation
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.
:white_check_mark: xe6077
:x: xe@dev2
xe@dev2 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.
Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @ilappe will know the proposed changes are ready to be reviewed. For your convenience, here is a link to the contributions SLAs document.
Hi @xe6077, thanks for contributing to the XSOAR marketplace. To receive credit for your generous contribution please follow this link.
Hi @xe6077 Thanks for your contribution! there is a few validation errors please check of you can solve them reach me here, if you need help with that thanks in advance
Hi, updated accordingly. Hope it now passes
@xe6077 Thank you! it's look like still failing please note that during the upcoming week (1st - 2nd of June), we will not be available due to an Israeli holiday, so i will review it again after that, and wiil happy to help if you need.
Thank you in advance for your patience and understanding.
Hi @xe6077 thanks again for your fixes, but it's look like still there is few issues:
- with the release notes validation, (you can ignore the velidation error regarding the
section). - with the cla
in addition, please attach a video demo that shown how the integration work with the contributed changes
thank in advance!
Hi @xe6077 we haven’t heard from you in a while. Do you need any help with the pull request?
Hi @xe6077 we haven’t heard from you in a while. Do you need any help with the pull request?
Hi @ilappe , sorry can't quite get to that currently. Maybe in the coming week. I can't sign the cla somehow - its already signed/filled out. Its just that i commited as well from another host/machine, could that cause an issue?
Hi @xe6077 we haven’t heard from you in a while. Do you need any help with the pull request?
Hi @ilappe , sorry can't quite get to that currently. Maybe in the coming week. I can't sign the cla somehow - its already signed/filled out. Its just that i commited as well from another host/machine, could that cause an issue?
Hi
try to run git rebase -i HEAD~NUM_OF_COMMITS to squash your commits into one
thanks!
Hi @xe6077, we haven’t heard from you in a while. Do you need any help with the pull request?
Hi @xe6077, we haven’t heard from you in a while. Do you need any help with the pull request?
Hi @xe6077, we haven’t heard from you in a while. Do you need any help with the pull request?
Hi @ilappe, will this fix the issue? Or does it really need the rebase besides the fix for the release notes? I didn't touch the sections as you've mentioned beforehand, so hope that's fine.
will this fix the issue? Or does it really need the rebase besides the fix for the release notes? I didn't touch the sections as you've mentioned beforehand, so hope that's fine.
Hi it's look like the CLA issue still exist