Demis D. John

Results 50 comments of Demis D. John

@jsenellart here’s another SegFault. good find isolating to passing a “Material” constructor, I’d never tried combing/separating them.

Need to install the `-static` versions of each dependency from MacPorts. Not sure they all have that variant ready to go.

Hi @jsenellart , Thanks for taking the time to work on this - Cpp memory errors being something I would never even start to work on, despite them being major...

@jsenellart I've added you as a collaborator to this repo - please feel free to merge pull requests as you deem fit. I'm happy to comment and help where I...

Issue #23 shows a memory error and possible trigger. Any idea if that is related to these fixes?

Trying this on this branch: https://github.com/demisjohn/CAMFR/tree/py35_compat

Stuff To fix: ``` camfr/camfr_wrap.cpp:580:3: error: void function 'init_module__camfr' should not return a value [-Wreturn-type] import_array(); ^~~~~~~~~~~~~~ /opt/local/Library/Frameworks/Python.framework/Versions/3.5/lib/python3.5/site-packages/numpy/core/include/numpy/__multiarray_api.h:1547:144: note: expanded from macro 'import_array' ..."numpy.core.multiarray failed to import"); return NUMPY_IMPORT_ARRAY_RETVAL; }...

After fixing "TabErrors", compiling (and failing due to above numpy issue), ahve a bunch of indentation errors! Numerous `def` and `if` statements are now incorrectly indented. Some of those might...

@demisjohn: Run 'diff' on py35 and py27 source files, look for indentation mistakes (I may have introduced some) Do the diff in GitHub: https://stackoverflow.com/questions/43552274/how-can-i-diff-two-branches-in-github Here's the diff link: https://github.com/demisjohn/CAMFR/compare/master...demisjohn:py35_compat

Corrected indentations to match old master version, in 7e1224c16297561ac468f142593d6b534a11e0d5 Some of the loops and function defs had been incorrectly indented, hopefully they are fixed. Have NOT yet run tests to...