sdb icon indicating copy to clipboard operation
sdb copied to clipboard

Add zfs_refcount command.

Open PaulZ-98 opened this issue 4 years ago • 2 comments

Pull request checklist

Please check if your PR fulfills the following requirements:

  • [x] Tests for the changes have been added (for bug fixes / features)
  • [x] Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • [x] Build was run locally and any changes were pushed
  • [x] Lint has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • [ ] Bugfix
  • [x] Feature
  • [ ] Code style update (formatting, renaming)
  • [ ] Refactoring (no functional changes, no api changes)
  • [ ] Build related changes
  • [ ] Documentation content changes
  • [ ] Other (please describe):

Issue Number: #192

What is the new behavior?

sdb> spa | member spa_refcount | zfs_refcount
0xffffffffc1089360   dsl_sync_task_common 
0xffff91223d23a000    
0xffff911f9659f000    
0xffff91223f870800    
0xffff91223f870800    
0xffff911f9659c000    
0xffff912249c9d800    
0xffff912249c9d800    
0xffff911f9659c000    
0xffff91223caa6800    
0xffff91223caa6800    
0xffff911f9659c000    
0xffff91223caa4800    

Does this introduce a breaking change?

  • [ ] Yes
  • [x] No

Other information

Requires a crash dump with reference tracking enabled, so some of the testing infrastructure was refactored.

PaulZ-98 avatar Mar 17 '21 19:03 PaulZ-98

Codecov Report

Merging #270 (b1de684) into master (d0cb398) will decrease coverage by 0.21%. The diff coverage is 67.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #270      +/-   ##
==========================================
- Coverage   87.69%   87.48%   -0.22%     
==========================================
  Files          63       64       +1     
  Lines        2577     2605      +28     
==========================================
+ Hits         2260     2279      +19     
- Misses        317      326       +9     
Impacted Files Coverage Δ
sdb/commands/zfs/zfs_refcount.py 67.85% <67.85%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d0cb398...b1de684. Read the comment docs.

codecov-commenter avatar Apr 16 '21 17:04 codecov-commenter

I made a version with just the zfs_refcount command and standard test.

PaulZ-98 avatar Apr 16 '21 18:04 PaulZ-98