ju

Leaving this here as a note for myself: https://dvcs.w3.org/hg/text-tracks/raw-file/default/608toVTT/608toVTT.html

Thanks for the feedback @nums, could you please submit a PR? I you don't have the time, I'll try to apply the patch myself.

Good point @notpeter, thanks for noticing.

@brion I tested your case just to be sure, and I can confirm: you PR fixes the issue. I'll wait for your feedback, and consider this issue as resolved.

You could show us the code and files you used?

Hello @sadikoff, thanks for the PR! :) Sorry I haven't been very responsive lately on PRs & issues submitted. I'll try my best to review yours properly by tomorrow!

A few months late, sorry, but this looks good to me! Thanks @sadikoff And thanks @weaverryan for the review (and reminder)!

Actually, that was done in the previous lib I wrote (https://github.com/delphiki/SubRip-File-Parser), and proper file encoding detection turned out to be nearly impossible with the php functions (mb_detect_encoding as you mentioned)....

That's true, I never took the time to write a proper documentation. The best way for now is indeed to look at the code. I hope I'll find the time...

This has been fixed, but it means your file did not contain any cue. Did you have any error when parsing the file?